Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect /system/system in TWRP #26

Open
ghost opened this issue May 12, 2019 · 7 comments
Open

Detect /system/system in TWRP #26

ghost opened this issue May 12, 2019 · 7 comments

Comments

@ghost
Copy link

ghost commented May 12, 2019

Hey, on my device, sailfish, system is mounted as /system/system. A way to detect this in pull-fileset and push-fileset would be appreciated.

@Lanchon
Copy link
Owner

Lanchon commented May 13, 2019

hi,
it seems like there's an issue with your twrp. could you provide a link that explains why system is and must be mounted this way?
thanks

@ghost
Copy link
Author

ghost commented May 14, 2019

This is official TWRP 3.3.0-0 builds, by the way.
ls /system:

acct
bin
bugreports
cache
charger
config
d
data
default.prop
dev
dsp
etc
firmware
init
init.environ.rc
init.rc
init.usb.configfs.rc
init.usb.rc
init.zygote32.rc
init.zygote64_32.rc
lost+found
mnt
odm
oem
persist
postinstall
proc
product
res
sbin
sdcard
storage
sys
system
ueventd.rc
vendor
verity_key

ls /system/system:

addon.d
app
bin
build.prop
compatibility_matrix.xml
etc
fake-libs
fake-libs64
fonts
framework
lib
lib64
media
priv-app
product
usr
vendor
xbin

@Lanchon
Copy link
Owner

Lanchon commented May 14, 2019

yeah, i'm surprised the FS is not mounted in /. i don't know if this is standard for the new layout. in any case, i don't have a test device so i can't fix it.

my push and pull scripts already adapt to a variety of layouts. it shouldn't be hard to support this. or, as a workaround, specialized scripts for this layout could be added. you are welcome to try your hand at it :)

@ghost
Copy link
Author

ghost commented May 14, 2019

A simple way to check would be df -h /system/system

@ghost
Copy link
Author

ghost commented May 20, 2019

@Lanchon this MAY be the reason, not sure: https://source.android.com/devices/bootloader/system-as-root

@Lanchon
Copy link
Owner

Lanchon commented May 20, 2019

yes i'm aware of the system as root FS situation. what i was asking was whether it was standard of TWRP to mount the fs in /system instead of / and where is that documented. but come to think about it, it makes sense to do it this way (although it is kinda horrible). i hate google and their stupid changes. anyway, i cannot fix it without a device so this will stay open for now.

@alextmz
Copy link

alextmz commented Jul 3, 2019

Hi Launchon, and thanks for the amazing work. I'll watch this one bug, as it blocks usage of the NanoDroid/TWRP combo (the easiest way to get microG) on Pixel/XL (sailfish/marlin) and maybe others.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants