Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

biquadfilter's high shelf and low shelf have no effect? #171

Open
meshula opened this issue Sep 6, 2021 · 0 comments
Open

biquadfilter's high shelf and low shelf have no effect? #171

meshula opened this issue Sep 6, 2021 · 0 comments

Comments

@meshula
Copy link
Member

meshula commented Sep 6, 2021

image

(the curve that's showing up is because I captured an image with Brown instead of White noise)

Not a LabSound issue... Here's the canonical WebAudio response curves; selecting the shelf variants, there doesn't seem to be any way to get a curve out of it, at least on Safari:

https://rtoy.github.io/webaudio-hacks/more/biquad/biquad-coef.html

The discussion here - https://github.com/WebAudio/web-audio-api-v2/issues/67 - seems to suggest that the behavior of the shelf modes is unsatisfactory.

So the shelves seem to be broken on WebAudio/WebKit as well. I think we either need proper shelving filters added as a switch inside the BiquadFilter, or we need a new node with a good implementation. Unless if I'm missing something obvious, and there's a parameter to set on the shelves to make it do .... anything at all

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant