Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

possibly cache things like validPixels #28

Open
esheldon opened this issue Jun 19, 2019 · 3 comments
Open

possibly cache things like validPixels #28

esheldon opened this issue Jun 19, 2019 · 3 comments

Comments

@esheldon
Copy link
Collaborator

clear the cache when the map is modified, e.g. by oring it with another etc.

@erykoff
Copy link
Collaborator

erykoff commented Jun 20, 2019

Good idea.

@erykoff
Copy link
Collaborator

erykoff commented Jul 6, 2020

I've looked into this, and with large high res maps it potentially increases the memory usage by a significant amount (e.g., the user would know whether they want to cache or not). At the same time, I significantly improved the speed of computing valid_pixels. Is this still thought to be necessary?

@kadrlica
Copy link

Calculating the valid_pixels of a wide map is still pretty time and memory intensive.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants