Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extend redshift range in N(z) test #138

Open
yymao opened this issue Aug 13, 2018 · 4 comments
Open

extend redshift range in N(z) test #138

yymao opened this issue Aug 13, 2018 · 4 comments

Comments

@yymao
Copy link
Member

yymao commented Aug 13, 2018

Currently the redshift distribution test, N(z), only goes to z = 1. We should extend the redshift range to z = 3 to make sure things look reasonable beyond z > 1. This is particular important for cosmoDC2.

The validation data is valid in the redshift range up to around z = 1.5, so we can plot the redshift range to z = 3, but don't use the data beyond z = 1.5 to calculate the chi^2.

cc @evevkovacs @rmandelb

@yymao
Copy link
Member Author

yymao commented Aug 13, 2018

Here's is a DESCQA run with simply modifying the N(z) test config file to increase the redshift range to z=3. Things look good.

Now we need to modify the code to allow setting a different validation range. I'll be developing this in the issue/138/extend-redshift-dist-test branch.

@aphearin
Copy link

Nice job on the modifications @yymao - this is a nice improvement of the dn/dz validation, and very timely for cosmoDC2. Many thanks!

@rmandelb
Copy link

Thanks for this, Yao!

Could we add a single panel for a deeper sample without any validation data, just for the basic sanity check that there are no extremely strange features? (I mean right now each section has 3 panels with a blank space, so could the blank space have everything down to i<25.3 without a validation dataset shown?) Or has a basic sanity check of the overall N(z) for a deeper sample already been done in another context?

@evevkovacs
Copy link
Contributor

@rmandelb @yymao The readiness test plots the basic distribution, as shown in this issue. The N(z) test does have the option of plotting distributions with no validation data. We just have to make a configuration file for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants