Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include input datasets as a field which can be returned from a query #10

Open
JoanneBogart opened this issue Jun 1, 2023 · 2 comments
Assignees
Labels
enhancement New feature or request medium_priority

Comments

@JoanneBogart
Copy link
Collaborator

Input datasets may be found by joining the dataset table with the dependencies table (just as is now done to return execution properties). However since more than one input may be associated with a dataset, some thought should be given to the form of the returned results.

@JoanneBogart JoanneBogart added the enhancement New feature or request label Jun 1, 2023
@JoanneBogart JoanneBogart self-assigned this Jun 15, 2023
@JoanneBogart
Copy link
Collaborator Author

JoanneBogart commented Jun 15, 2023

There is code (untested and appears to be wrong) to create the entries in the dependency table, but that table currently associates a dataset with its dependency datasets. If an execution has several outputs, each would have similar entries in the dependency table, which seems wasteful. The dependencies are really associated with the execution. However currently the execution_id argument to register_dataset is optional and there might be legacy datasets where no true execution entry can be made. In this case (no execution id supplied) register_dataset could make a minimal entry in the execution table.

@JoanneBogart
Copy link
Collaborator Author

With the merge of u/jrbogart/dependencies the dependencies are now properly stored in the db.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request medium_priority
Projects
None yet
Development

No branches or pull requests

1 participant