Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to pyproject.toml instead of setup.py #69

Open
espenhgn opened this issue May 9, 2023 · 4 comments
Open

Move to pyproject.toml instead of setup.py #69

espenhgn opened this issue May 9, 2023 · 4 comments
Assignees
Labels
enhancement New feature or request
Projects

Comments

@espenhgn
Copy link
Contributor

espenhgn commented May 9, 2023

This is now the new standard: https://packaging.python.org/en/latest/specifications/declaring-project-metadata/#declaring-project-metadata

@espenhgn espenhgn added the enhancement New feature or request label May 9, 2023
@espenhgn espenhgn self-assigned this May 9, 2023
@espenhgn espenhgn added this to To do in Release 0.2 via automation May 9, 2023
@torbjone
Copy link
Collaborator

It would be nice if we could release v0.2 relatively soon, is this something that we should look into first, or should we postpone this to a later release?

@espenhgn
Copy link
Contributor Author

Let's postpone this until it's in place in LFPykit, LFPy, and MEAutility. I still didn't see any deprecation warnings or such even when installing LFPy fresh for instance:

% conda create -n "lfpytest" python=3 pip -y
% conda activate lfpytest
% pip install lfpy

So we can release the current version as 0.2 as is, I think.

@espenhgn espenhgn removed this from To do in Release 0.2 May 23, 2023
@espenhgn espenhgn added this to To do in Release 0.3 via automation May 23, 2023
@espenhgn espenhgn removed this from To do in Release 0.3 May 23, 2023
@espenhgn espenhgn added this to To do in Release 0.2 via automation May 23, 2023
@espenhgn
Copy link
Contributor Author

Well, this didn't go well:
https://github.com/LFPy/LFPykernels/actions/runs/5054546283/jobs/9069593692?pr=73

I'll try and fix it later but will start with LFPykit. Or do you want to investigate?

@torbjone
Copy link
Collaborator

In this case, I wonder if the problem was simply that the version ended up as '0.2.', with the trailing '.', and apparently it is common to include a patch version even if it is '0'.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Development

No branches or pull requests

2 participants