Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove/redo SphericallySymmetricVolCondMEG.calculate_H_from_iaxial() #436

Open
espenhgn opened this issue Oct 31, 2022 · 2 comments
Open

Comments

@espenhgn
Copy link
Collaborator

espenhgn commented Oct 31, 2022

It makes little sense to include this method with the SphericallySymmetricVolCondMEG class, as the formula is mainly valid with infinite homogeneous volume conductors. It should remain in the InfiniteHomogeneousVolCondMEG class.

If this method should stay, it needs to be modified to use the correct formula from Sarvas J., Phys.Med. Biol., 1987, Vol. 32, No 1, 11-22 as implemented by the parent LFPykit.eegmegcalc.SphericallySymmetricVolCondMEG class.
It should also check that all source radii is less than the measurement site radius.

@espenhgn espenhgn added this to the v2.3 milestone Oct 31, 2022
@espenhgn espenhgn added this to To do in v2.3 via automation Dec 14, 2022
@espenhgn
Copy link
Collaborator Author

Accidentally pushed e441281 to master, which will raise an NotImplementedError when this method is called. Leaving this issue open, in case someone will implement this feature.

@espenhgn espenhgn modified the milestones: v2.3, v2.3.1 Dec 15, 2022
@github-actions
Copy link

This issue appears to be stale due to non-activity and will be closed automatically

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
v2.3
To do
Development

No branches or pull requests

1 participant