Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't wait forever for serial output when reading FW version #7

Open
mrcity opened this issue Aug 23, 2014 · 1 comment
Open

Don't wait forever for serial output when reading FW version #7

mrcity opened this issue Aug 23, 2014 · 1 comment
Assignees
Labels

Comments

@mrcity
Copy link
Contributor

mrcity commented Aug 23, 2014

I don't think a timeout was implemented in the code, so if the Python program doesn't receive any data back from a firmware version poll, it'll hang until it finds 3 bytes of data. The preferable fix would be to read all input within 1 second of the request (whether 3 bytes or not), then stop.

@mrcity mrcity added the bug label Oct 16, 2014
@mrcity mrcity self-assigned this Jul 7, 2015
@mrcity
Copy link
Contributor Author

mrcity commented Jul 7, 2015

A timeout has been hard-coded so that the serial read will expire after two seconds. This variable should be placed into a global instead of hard-coded in several different places. However, the original issue (of application hanging) is resolved as of 1.2.1a.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant