Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing dselect and other functions from dataops.jl #205

Closed
smahoff opened this issue May 9, 2022 · 3 comments
Closed

Missing dselect and other functions from dataops.jl #205

smahoff opened this issue May 9, 2022 · 3 comments
Assignees

Comments

@smahoff
Copy link

smahoff commented May 9, 2022

Versions after 0.6.8 have the majority of functions erased from dataops.jl

Any

Steps to reproduce

1. Install latest GigaSOM
2. Import distributed dataset
3. Run dselect

Expected behavior
dselect works

Actual behavior
dselect won't be found

Additional information

@exaexa
Copy link
Collaborator

exaexa commented May 10, 2022

Hi! Thanks for pointing this out. The functions weren't erased, but actually moved to a separate, more general package -- you should be able to fix the issue by just importing DistributedData.jl.

Seeing this issue, I have to say that the change was not announced super-loudly, but we did an incompatible version bump to 0.7 and updated the docs.

I guess we could improve with highlighting the change a bit more visibly in the main README? (EDIT: at least I pinned this issue so that it's easily visible :] )

(Originally, I was thinking that we could re-export the functions from DistributedData through GigaSOM, but I wanted to avoid namespace pollution and name collisions for people who don't do distributed stuff.)

@exaexa exaexa self-assigned this May 10, 2022
@exaexa exaexa changed the title Many functions erased from dataops.jl Missing dselect and other functions from dataops.jl May 10, 2022
@exaexa exaexa pinned this issue May 10, 2022
@smahoff
Copy link
Author

smahoff commented May 10, 2022

Thanks for the quick clarification! Just from looking at the GitHub page/install instructions or searching for dselect in the latest version docs/source it wasn't immediately apparent (unless one jumps to tutorial 3). Thanks again!

@exaexa
Copy link
Collaborator

exaexa commented May 10, 2022

OK, good that this was indeed the problem -- I was afraid of something more complicated. :D

I'll leave this issue pinned so that others can easily find the solution.

@exaexa exaexa closed this as completed May 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants