Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow users to point to a local Radiance installation. #21

Open
sariths opened this issue Aug 4, 2023 · 4 comments
Open

Allow users to point to a local Radiance installation. #21

sariths opened this issue Aug 4, 2023 · 4 comments
Labels
enhancement New feature or request question Further information is requested

Comments

@sariths
Copy link
Collaborator

sariths commented Aug 4, 2023

Edit: Based on the discussion below, this issue is a feature request for allowing users to set their own PATH and RAYPATH directories instead of relying on compiled binaries from pyradiance.

@taoning , How does one do a version check for Radiance executables? I tried running a rcontrib(params=['-version']) check but that did not work (because of required params).

Secondly, on Windows some executables are still being "compiled" as a perl files. Genbsdf is available as both perl and exe.
image

Does it make sense to allow the users to override the pyradiance bin and choose their local Radiance installation instead?

@sariths sariths added the question Further information is requested label Aug 4, 2023
@taoning
Copy link
Collaborator

taoning commented Aug 4, 2023

Version check can be done with:
radiance_version = pr.rtrace(None, None, version=True)

Perl file should all be converted to .exe. If not, then there is a bug in the setup.py.

Regarding letting users to point to local Radiance installation, I think one can set pr.BINPATH to any Radiance binaries directory.

@taoning
Copy link
Collaborator

taoning commented Aug 4, 2023

Actually, setting pr.BINPATH directly wouldn't work since it's immutable. We'd need to make a dictionary called something like PATH and do PATH['bin'] = BINPATH. Then one can change PATH['bin'] to something else.

@sariths
Copy link
Collaborator Author

sariths commented Aug 4, 2023

Actually, setting pr.BINPATH directly wouldn't work since it's immutable. We'd need to make a dictionary called something like PATH and do PATH['bin'] = BINPATH. Then one can change PATH['bin'] to something else.

2023-08-04 11_04_09-pyradTest – checkOconv py

Yup, I can confirm as much (I changed the path of rtrace after setting the BIN, so it should have returned an error but it didn't).

Perl file should all be converted to .exe. If not, then there is a bug in the setup.py.

This does not work right now (does not convert to exe). Should this be a separate issue then?

@taoning
Copy link
Collaborator

taoning commented Aug 4, 2023

yes please

@sariths sariths changed the title Version check? Allow users to point to a local Radiance installation? Allow users to point to a local Radiance installation. Aug 4, 2023
@sariths sariths added the enhancement New feature or request label Aug 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants