Shading layer with zero thermal openings

[vidanovic]

Shading layer with zero thermal openings is not behaving the same as solid layer for tarcog calculations. As results following code was inserted.
std::shared_ptr
Layers::shading(double thickness,
double conductivity,
EffectiveLayers::EffectiveOpenness effectiveOpenness,
double frontEmissivity,
double frontTransmittance,
double backEmissivity,
double backTransmittance)
{
if(effectiveOpenness.isClosed())
{
return solid(thickness,
conductivity,
frontEmissivity,
frontTransmittance,
backEmissivity,
backTransmittance);
}

        return std::make_shared<CIGUShadeLayer>(
            thickness,
            conductivity,
            std::make_shared<CShadeOpenings>(effectiveOpenness.Atop,
                                             effectiveOpenness.Abot,
                                             effectiveOpenness.Al,
                                             effectiveOpenness.Ar,
                                             effectiveOpenness.Ah,
                                             effectiveOpenness.FrontPorosity),
            std::make_shared<CSurface>(frontEmissivity, frontTransmittance),
            std::make_shared<CSurface>(backEmissivity, backTransmittance));
    }

Check why std::make_shared with zero effective openings is not giving same results as
return solid(thickness,
conductivity,
frontEmissivity,
frontTransmittance,
backEmissivity,
backTransmittance);

[RDmitchell]

@vidanovic -- how did this come up?

Is this a high priority for THERM 8?

Or can we put it in the bucket for the NFRC (and AERC) fixes for November?

[vidanovic]

Was helping @StephenCzarnecki with his part. That is how we came to this.