Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong TimeStamp type in recob::OpWaveform #37

Open
jroto opened this issue May 19, 2023 · 2 comments
Open

Wrong TimeStamp type in recob::OpWaveform #37

jroto opened this issue May 19, 2023 · 2 comments

Comments

@jroto
Copy link

jroto commented May 19, 2023

Recob::OpWaveform is an intermediate class between raw::OpDetWaveform and recob::OpHits. Right now raw::OpDetWaveform provides a timestamp of double type, and recob::OpHits require also a double, however recob::OpWaveform stores the timestamp as a raw::RDTimeStamp.
There is a PR in duneopdet to implement this class, and we are forced to read raw::OpDetWaveforms just to take the timestamp when creating OpHits, which looks quite inefficient:
DUNE/duneopdet#27 (comment)

The timestamp type should be changed from recob::raw::RDTimeStamp to a double, or add a new member to store this double.

raw::RDTimeStamp fTimeStamp; ///< Time stamp

@yangtj207
Copy link
Member

Sorry about the delay. The change has just been merged.

@jroto
Copy link
Author

jroto commented Oct 26, 2023

Great, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants