Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Group nearby tags #22

Open
L0laapk3 opened this issue Feb 16, 2019 · 5 comments
Open

Group nearby tags #22

L0laapk3 opened this issue Feb 16, 2019 · 5 comments
Labels
enhancement New feature or request frontend issue for the web interface

Comments

@L0laapk3
Copy link
Owner

No description provided.

@L0laapk3 L0laapk3 added enhancement New feature or request frontend issue for the web interface labels Feb 16, 2019
@L0laapk3
Copy link
Owner Author

Deduplicate tags from different snapshots on the timeline, and group the nearby ones together and maintain a constant spacing between them.

@MeeperBeeper
Copy link

MeeperBeeper commented Nov 16, 2019

Just an idea, but instead of trying to group the tags from the different snapshots, why not have the tags tied to the individual snapshot times. As you change what time you're viewing you change what tags are shown too.

In other words, instead of showing all tags across all times for each individual time, only show the tags that belong to that time. IIRC (I'm not on my home PC at the moment), you already have the tags grouped by time in the json data you save, so why not show the tags for the individual times instead of trying to figure out how to group them with some kind of fuzzy logic about how close they have to be to group together.

This also opens up the possibility of removing the option "no-tag" from the auto.py script altogether. Instead of making the choice at the time of map creation, move the choice of displaying the tags or not to the browser display. This way they can be turned on and off at will long after the map has been generated.

@L0laapk3
Copy link
Owner Author

Thanks for the feedback, if I ever decide to implement this I will keep this into account, however realistically speaking it's unlikely I'll be implementing this anytime soon as I'm quite burned out on factorio at the moment. (Also quite busy)

As a sidenote, I am always open to pull requests :p

@MeeperBeeper
Copy link

I can certainly understand that. No guarantees of course but I might be able to help out a little bit here and there (my own time allowing). I'm still pulling your mod apart to find out just exactly how it works though.

@L0laapk3
Copy link
Owner Author

L0laapk3 commented Nov 22, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request frontend issue for the web interface
Projects
None yet
Development

No branches or pull requests

2 participants