Skip to content
This repository has been archived by the owner on Sep 13, 2020. It is now read-only.

Can we get a new release please? #398

Open
iamnader opened this issue Apr 9, 2020 · 15 comments
Open

Can we get a new release please? #398

iamnader opened this issue Apr 9, 2020 · 15 comments

Comments

@iamnader
Copy link

iamnader commented Apr 9, 2020

Question

1.1.3 is the latest release and is a little old

@Cookizza
Copy link

This component needs a few changes as it currently uses componentWillMount and componentWillReceiveProps - which are now deprecated.

@jdewells
Copy link

Would love to see a new release purely to fix the warnings for componentWillReceiveProps.

@cameronmurphy
Copy link

cameronmurphy commented Jun 15, 2020

+1 here. This is the best alternative to react-native-drawer which has been abandoned. Even just a release that renames componentWillMount to UNSAFE_componentWillMount and componentWillReceiveProps to UNSAFE_componentWillReceiveProps would be handy so we can be compatible with React 17

@gonzalodiazcavuoti
Copy link

Any news about this?

@alessiocancian
Copy link

alessiocancian commented Jun 18, 2020

Hi guys, I released an updated version of this package to npm, you can find it here: https://www.npmjs.com/package/react-native-side-menu-updated

You can install it and change your imports from react-native-side-menu to react-native-side-menu-updated to use it.

I found that this repository already has all the changes about UNSAFE_componentWillMount and UNSAFE_componentWillReceiveProps, and the fixes for Animated useNativeDriver not specified, I added only index.d.ts and published the package.

@gonzalodiazcavuoti
Copy link

Thanks @alessiocancian . It worked for me

@dezudas
Copy link

dezudas commented Jun 20, 2020

@alessiocancian thank you for the initiation, it could have been great if this was updated.

@jcarioti
Copy link

All these new commits mean nothing if there isn't a release! What's going on with regards to getting these changes pushed? It's been crickets in here for a while.

@danleveille
Copy link

@alessiocancian Is your updated package on Github too?

@safaiyeh
Copy link

cc @Naturalclar

@alessiocancian
Copy link

@alessiocancian Is your updated package on Github too?

Yes, you can find the fork here: https://github.com/alessiocancian/react-native-side-menu

@safaiyeh
Copy link

Hey all! Apologies for the lack of releases, I'll break down the situation with this package and gauge how y'all feel about the future of it.

Current problem is that the org does not own the npm package react-native-side-menu and the owner is no longer actively maintaining the repo or making releases.

Our options:

  1. The org no longer maintains react-native-side-menu and people are free to fork the repo and continue better maintenance as @alessiocancian took initiative on.
  2. We release the package under the org @react-native-community/side-menu and @Naturalclar can help maintain and I'm sure someone from the community can join to help as well.

Let me know what y'all think!

@danleveille
Copy link

@safaiyeh Either option sounds great to me. As long as someone can approve pull requests, I'm sure either option will work. 😄

@GamesOfSummer
Copy link

Either works, just let us know the decision.

@safaiyeh
Copy link

safaiyeh commented Sep 4, 2020

Hey all,

Some news on the front. There will be some changes in the react-native-community and we won't be supporting as many modules. Would love to see an active maintained fork to succeed this.

We are going to go with option #1 I mentioned above and I'm willing help out the transition. Depending on if @alessiocancian wants to help support future development or a different fork, let me know!

Apologies for the lack of releases and this limbo state of nothing happening.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests