Replies: 5 comments 9 replies
-
|
plugin is now fully functional, there where some issues with the captcha validation rule where the Joomla provided rule always validates when on an article page (which we where) and when articles parameters have captcha disabled (IMO this is a Joomla issue as it makes the captcha useless when used by e.g. a plugin or module on an article page). |
Beta Was this translation helpful? Give feedback.
-
|
Hello, The modules and plugins uses the legacy part instead of using the HMVC way like it was done in Kunena. I will give a try |
Beta Was this translation helpful? Give feedback.
-
|
Top, the way I refactored doesn't uses the Kunena template at all: pure joomla :) If you need an installable package, please let me know. It installs as is: no cleanup of previous version so that may lead to issues > best to uninstall old one and install this one. |
Beta Was this translation helpful? Give feedback.
-
|
I have tried your changes but now when add message with the form under the article it's not added and the topic related to the article isn't created |
Beta Was this translation helpful? Give feedback.
-
|
The Submit button does not send the message, it only refreshes the page. This is the problem. |
Beta Was this translation helpful? Give feedback.
-
found the issue (was when posting with account), fixed now |
Beta Was this translation helpful? Give feedback.
-
|
Hi, working for me (using this in production now on multiple sites). |
Beta Was this translation helpful? Give feedback.
-
|
The build process works in the original repository, what is the issue with build process ? |
Beta Was this translation helpful? Give feedback.
-
BUILD FAILED Total time: 0.4080 seconds Maybe due to other phing version? building kunenaforum works as expected |
Beta Was this translation helpful? Give feedback.
-
|
Ok, thanks for the explanation, never use that setting (only create on first reaction as otherwise my forum fills with 'empty' topics. |
Beta Was this translation helpful? Give feedback.
-
|
fixed :) |
Beta Was this translation helpful? Give feedback.
-
|
Beta Was this translation helpful? Give feedback.
-
|
Can-you make a PR please against the K6.0 branch : https://github.com/Kunena/Kunena-Addons/tree/K6.0 ? |
Beta Was this translation helpful? Give feedback.
-
|
Done: Kunena/Kunena-Addons#294 |
Beta Was this translation helpful? Give feedback.
-
Hi,
just did a complete overhaul of the discuss plugin here: https://github.com/Ruud68/Kunena-Addons/tree/refactored-j4
With these changes, Kunena Discuss is:
*This is a working test / draft version.
* What I run into and is not fully working are the layouts: you can now select a layout in the plugin advanced parameters (currently: default or aurelia)But because the plugin doesn't load the messages (topic items) via a Joomla / plugin layout the layouts only work partially. method KunenaForum::display('Topic', 'default', null, $params); will always load the default layout files (from the Kunena template) and NOT the configured layout files for the plugin. So even if you set aurelia in the plugin, it will load e.g. the aurelia_form.php, aurelia_login.php, etc. but not the aurelia.php / aurelia_left.php etc. files > it will always load the default.php and default_left.php files.IMO it would be better if we could use the template files configured in the plugin and not use kunenaforum::display to display the messages / topics.EDIT: refactored the template / layouts and removed the hardcoded Kunena template dependency for messages. Kunena Discuss can now have independent templates (tmpl) that are fully overridable via Joomla template overrides
Thoughts?
Beta Was this translation helpful? Give feedback.
All reactions