[Bug]: Canary - KryptonCustomPaletteBase --> null reference

[AngeloCresta]

Hi, I have a reference null exeption in SetPalette(..) method KryptonCustomPaletteBase.cs (ln 5845 - Canary)

I suggest to modify the code initializing the basePalette if null:

   private void SetPalette(PaletteBase basePalette)
        {
            if (basePalette == null)
            {
                basePalette  = new KryptonCustomPaletteBase();
            }
            ....

Regards,
Angelo

[giduac]

Hi @AngeloCresta

Which version of the toolkit are you using?
Did you try other versions, and if so was the error present as well ?
Can you please provide a simple sample project that demonstrates the error?

[AngeloCresta]

<TargetFrameworks>net8.0-windows</TargetFrameworks>

Not really, the project is huge and integrates Krypton at many levels with my other framework (ModernUI) and I've faced that error on integrating the canary version (due to all the breaking changes introduced..)

I can modify the code once is released don't worry.

Here the sample "palette designer" application behaviour with ModernUI form and theme and color with all the krypton controls styled accodingly (slow - debug)

Regards,
Angelo

[giduac]

Which Canary version of the toolkit are you using?

[AngeloCresta]

I grab the version from GitHub yesterday, based on your label v90.24.4.113-beta

[giduac]

The above video does not show anything going wrong.
The current code actually does null checking and that code is also present in the master branch. So earlier versions will act the same.

So we need some more info about how & what exactly is happening?

        private void SetPalette(PaletteBase basePalette)
        {
            if (basePalette != _basePalette)
            {
                Debug.Assert(_basePalette != null);

                // Unhook from current palette events
                if (_basePalette != null)
                {
                    _basePalette.PalettePaint -= OnPalettePaint;
                    _basePalette.ButtonSpecChanged -= OnButtonSpecChanged;
                    _basePalette.BasePaletteChanged -= OnBasePaletteChanged;
                    _basePalette.BaseRendererChanged -= OnBaseRendererChanged;
                }

                // Remember the new palette
                _basePalette = basePalette;

                // Make sure the redirector passes requests onto the base palette
                _redirector.Target = _basePalette;

                // Update the color table we inherit from
                ToolMenuStatus.BaseKCT = _basePalette.ColorTable;

                // Hook to new palette events
                if (_basePalette != null)
                {
                    _basePalette.PalettePaint += OnPalettePaint;
                    _basePalette.ButtonSpecChanged += OnButtonSpecChanged;
                    _basePalette.BasePaletteChanged += OnBasePaletteChanged;
                    _basePalette.BaseRendererChanged += OnBaseRendererChanged;
                }
            }
        }

[AngeloCresta]

No, because I've added this on the method:

   private void SetPalette(PaletteBase basePalette)
        {
            if (basePalette == null)
            {
                basePalette  = new KryptonCustomPaletteBase();
            }
            ....

Commenting it out I have:

But, as I said, is up to you ...
Angelo

[giduac]

I see, but: basePalette is not nullable and should be a valid param to a palette.

[AngeloCresta]

Ok, I'll update my code to be sure that the custom palette is always inialized.
Thanks