Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Suggestion] Addition of a second button in the launcher settings window #18

Open
La1eon opened this issue Oct 15, 2019 · 0 comments
Open
Labels
enhancement New feature or request

Comments

@La1eon
Copy link

La1eon commented Oct 15, 2019

When I opened the launcher settings window for the first time, changed several options, and tried to discard them, I became a little confused. This launcher had only "Save and apply" button in the settings window, and since a lot of Windows and Linux programs have "Save" (or "OK") and "Cancel" buttons, and often also "Apply", I got used to the fact that when I want to discard changes, the best way to do so is to click "Cancel" (or similar) button, so at first I didn't know what to do to discard the changes made by me in the options. After a longer while I thought I can use the "X" button in the title bar. But even after clicking it I wasn't sure whether the changed options became discarded or not, so I opened the settings window again to check it out.

I have 2 variants here (personally I like the variant B more, since it is probably easier to implement):

  • (A) Modification of the existing "Save and apply" (which could be renamed to simply "Save") button behavior – it will now save changes and close the launcher settings window – and addition of a second button (named e.g. "Cancel") next to the existing one, which will close the launcher settings window without saving changes.
  • (B) Addition of a second button (named e.g. "Cancel") next to the existing one, which will close the launcher settings window without saving changes. The existing "Save and apply" (which could be renamed to simply "Save", or "Apply", since it doesn't close the window) button behavior will become unchanged – it will still save changes without closing the launcher settings window.

I mean something like this:
Save-cancel-buttons

@Kron4ek Kron4ek added the enhancement New feature or request label Oct 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants