Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possibly remove CMNode.stringContent #48

Open
NightFlyer opened this issue May 30, 2019 · 0 comments
Open

Possibly remove CMNode.stringContent #48

NightFlyer opened this issue May 30, 2019 · 0 comments

Comments

@NightFlyer
Copy link
Collaborator

I think that stringContent is really just something that is internal to the parser and isn't really something that should be exposed as part of Maaku.

Note:

  • cmark_node_get_string_content is defined in cmark-gfm-extension_api.h, not cmark-gfm.h as the other public methods are. The other methods in cmark-gfm-extension_api.h mostly deal with the parser. The only methods from there which are useful are the ones we need to get the syntax extension.
  • the string content is never used in any of the rendering methods. This implies to me that it isn't used for any output, and so probably isn't useful for Maaku users.

At the very least, I think this all means that there is little reason to be able to set the value, and so Issue #45 shouldn't have to provide a setter function for the string content.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant