-
-
Notifications
You must be signed in to change notification settings - Fork 643
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support text-emphasis #2024
Comments
Hi!
|
Hello! This is my first open-source contribution and I'm excited to be a part of it. I have some questions about how to implement these features. I am working on the following properties:
I started to add Codecss/validation/properties.py # ln-1605
@property()
@single_keyword
def text_emphasis_style(keyword):
return keyword in ('filled', 'open') Is there a clear explanation about these decorators? css/properties.py.INITIAL_VALUES # ln-191
'text_emphasis_style': 'none', I added testingtest_file.html <style>
p.ex1 {
text-emphasis-style: filled;
text-emphasis-color: red;
}
</style>
<p class="ex1">This is some text.</p> logs.log
This feature requires position changes, such as putting text above a text, vertical orientation, etc, what would be the process to add this feature? Thank you for being patient. |
Hi @SrGitQ Sorry for the delay, and thanks for your code! It’s often easier to review code using pull requests. You can open a draft pull request if your code isn’t ready yet.
The decorators are documented in
Yes, it’s inherited.
\o/
If text emphasis doesn’t change the layout (to be verified in the specification), you follow what’s done for text decoration. |
I want these feature:
But these feature is not support on latest version 60.2
Thank you.
The text was updated successfully, but these errors were encountered: