Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: (doctest) build issue with glibc 2.34 #2333

Open
DeckerSU opened this issue Jul 26, 2023 · 1 comment
Open

[BUG]: (doctest) build issue with glibc 2.34 #2333

DeckerSU opened this issue Jul 26, 2023 · 1 comment
Labels
bug Something isn't working dependencies next iteration to not forget to include it

Comments

@DeckerSU
Copy link
Contributor

Since the SIGSTKSZ is no longer a statically defined variable:

build the project with glibc 2.34 will fail with error like this:

[ 71%] Built target komodo-wallet_autogen
In file included from /home/decker/komodo-wallet-desktop/build/src/CMakeFiles/komodo-wallet_tests.dir/Unity/unity_0_cxx.cxx:13:
In file included from /home/decker/komodo-wallet-desktop/src/tests/atomic.dex.tests.cpp:23:
/home/decker/komodo-wallet-desktop/ci_tools_atomic_dex/vcpkg-repo/installed/x64-linux/include/doctest/doctest.h:4041:33: fatal error: variable length array declaration not allowed at file scope
        static char             altStackMem[4 * SIGSTKSZ];
                                ^           ~~~~~~~~~~~~
[ 97%] Built target komodo-wallet
1 error generated.
gmake[2]: *** [src/CMakeFiles/komodo-wallet_tests.dir/build.make:349: src/CMakeFiles/komodo-wallet_tests.dir/Unity/unity_0_cxx.cxx.o] Error 1

It can be temp. fixed with something like:

sed -i 's/altStackMem\[4 \* SIGSTKSZ\]/altStackMem\[4 \* 8192\]/g' ci_tools_atomic_dex/vcpkg-repo/installed/x64-linux/include/doctest/doctest.h

before build.

But better to update doctest in a project from v2.3.8 to v2.4.8.

@DeckerSU DeckerSU added the bug Something isn't working label Jul 26, 2023
@smk762
Copy link
Collaborator

smk762 commented Sep 10, 2023

Thanks @DeckerSU
If you can confirm v2.4.8 has passed sec review, we can update https://github.com/KomodoPlatform/doctest/ and I'll update the portfile.cmake in this repo to use the newer version in our fork

@smk762 smk762 added the next iteration to not forget to include it label Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working dependencies next iteration to not forget to include it
Projects
None yet
Development

No branches or pull requests

2 participants