Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KHR_materials_volume extension doesn't state intended color spaces for properties #2322

Open
hybridherbst opened this issue Sep 8, 2023 · 2 comments

Comments

@hybridherbst
Copy link

hybridherbst commented Sep 8, 2023

While looking into a few color management problems I've come across at least one extension where the intended color space is not specified.

These readmes explicitly mention intended color space:

These don't:

@lexaknyazev
Copy link
Member

The base spec and all extensions follow the same rules:

  • All JSON numbers, e.g., base color factor, specular color factor, clearcoat factor, thickness factor, are linear multipliers.
  • Non-color textures, e.g., metallic roughness texture, transmission texture, contain linear values, i.e., an 8-bit value of 0x80 means 0.502.
  • Color textures, e.g., base color texture, sheen color texture, specular color texture, contain sRGB-encoded values, i.e., an 8-bit value of 0x80 means 0.216.

Volume attenuation color is a bit unique because it is not texturable but the general rule still applies: JSON numbers are linear. We should clarify the extension spec.

/cc @emackey

@donmccurdy
Copy link
Contributor

donmccurdy commented Sep 8, 2023

I really wish we could use the terms "Linear", "sRGB" or "Rec. 709", and "D65" when describing these factors. I understand that we're dancing around a tricky distinction — multiplicands whose product is a Linear-Rec709-D65 color. But I don't think "linear multiplier" is giving the reader enough context to understand that. Particularly as more tools begin supporting additional linear color spaces.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants