-
Notifications
You must be signed in to change notification settings - Fork 393
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Windows build not working #7891
Comments
@christophe-lunarg you said you had this exact same issue yesterday on Windows... how did you get around it? |
pinging @artem-lunarg / @arno-lunarg as well as our new Window Build experts 😄 |
This part should be straighforward. Debug word should be replaced with Release. Then the test project should be selected as a startup project: I personally use the following sequence to build the project the first time, this will also generates a VS solution. There is no option to have debug and release configuration in a single solution, I just create two solutions for release and debug in separate folders.
|
I cleared everything and generate the solution again... |
Yes, for this specific project. Even if you can select different configurations in combo box I don't think you can build, for example, Release configuration if project was generated for Debug, and vise versa. |
I think these components are not part of the official build configuration so yes, that might not work. |
@MennoVink sorry to ask, but is the window build working now as expected or is there still something actionable we need to take to fix the CMake code? |
@spencer-lunarg My expectations may be different from yours, so it's up to you to decide which issues to fix and which ones to ignore. In my view the proposed solutions are workarounds, not fixes. Here's a summary of the issues touched on in the discussion above:
I've been testing a bit more with the Test Explorer, that works on a different machine of mine, so this is most likely user error. |
VVL's CMake code fine. The problem is update_deps.py. That script/workflow was originally developed for single configuration generators like Make / Ninja. It doesn't work that well with Xcode, Visual Studio, etc. This line of code right here is a hack. CMAKE_BUILD_TYPE should NOT be used this way. This script was written a while ago and likely developed on Linux where you could basically get away with this.
That's fine. Just requires making UPDATE_DEPS=ON by default. That will annoy some package managers though. Since many do NOT want us to use that script. It's fine for development. But in terms of performance/security it's not great. |
To be clear that's not the only line of code that needs to be fixed. It's just the main indicator of the problem. |
Environment:
Describe the Issue
I cannot build the repo after having a fresh checkout. First i checked opening the folder with CMake GUI. When that didn't work i followed these steps which are giving me the same problems:
Expected behavior
With cmake gui i expect to be able to select the source directory, target directory as build subfolder and then press Configure->Generate->Open Project and end up in a visual studio instance able to build the project.
Additional context
The steps here do give me a visual studio project. But it wont build in release nor will the test explorer allow me to run any tests.
The text was updated successfully, but these errors were encountered: