Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make vulkaninfo removal of promoted extension structures optional #963

Open
charles-lunarg opened this issue Mar 7, 2024 · 2 comments
Open
Labels
enhancement New feature or request vulkaninfo

Comments

@charles-lunarg
Copy link
Contributor

charles-lunarg commented Mar 7, 2024

PR #948 removed extension structures from vulkaninfo output that were promoted to core Vulkan, eg into the VkPhysicalDeviceVulkan(11|12|13)(Features|Properties) structs. It was done for Vulkan profile generation, but it users who are looking for the extension structures explicitly as they no longer appear.

PR 948 was a necessary contribution to allow correct Vulkan-Profile output, but should be a command line option, eg --remove-promoted-extensions --strip_duplicate_struct.

@charles-lunarg charles-lunarg added enhancement New feature or request vulkaninfo labels Mar 7, 2024
@christophe-lunarg
Copy link

christophe-lunarg commented Mar 7, 2024

In the Vulkan Profiles merge script, the argument is called --strip_duplicate_struct if we want to be consistant. If you prefer a different name, I'll happy to use that name.

(It's not promoted extensions, but the structures, even promoted structures, that are removed)

@charles-lunarg
Copy link
Contributor Author

--strip_duplicate_struct is a much better name, because 'strip' better describes whats happening.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request vulkaninfo
Projects
None yet
Development

No branches or pull requests

2 participants