-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1.3.275.0: build fails because missing volk
detection in cmake
#959
Comments
Second thought .. |
The way this repo is typically built is using the update_deps.py script, which goes and downloads the dependencies automatically. The repo knows how to do this for you by passing |
This repo uses cmake build automation and in that automation shuld be checking all build dependencies. Nevertheless if that python script will be incorporated here it will be no external dependencies (sing just KISS principle). |
Apologies, I didn’t clarify that the script is located at scripts/update_deps.py. I mentioned “-DUPDATE_DEPS=ON” because then you don’t even need to know about where the script is located in the repo. |
Just checked that scrip.
|
And .. none of the other any cmake/meso/GNu autotools build automations takes care of what packaging software is using. I can understand that this options allow you to easy build all vulkan components when they are not yet released but using that thing outside of vulkan CIs should be forbidden and implemented not in cmake but only in CI procedure) |
I didn't realize you were trying to package the repo. The way to provide the volk dependency is through the VOLK_INSTALL_DIR, just like the Vulkan-Headers dependency. Yes, update_deps.py is meant for upstream development of the repo rather than downstream consumers like the SDK builds or package maintainers. Apologoies for the confusion. |
No problem 👍 Just please consider incorporate that script into vulkan-tools or generally include kind of generator of those two files because packaging volk only to be used by vulkan-tools is kind of overcomplication/overkill. |
cmake
And build fails with
The text was updated successfully, but these errors were encountered: