Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mock ICD should either report 1.1 support, or fix UpdateAfterBind limits #725

Open
ShabbyX opened this issue Dec 21, 2022 · 3 comments
Open
Assignees
Labels

Comments

@ShabbyX
Copy link
Contributor

ShabbyX commented Dec 21, 2022

Context: https://gitlab.khronos.org/vulkan/vulkan/-/issues/3324

The Vulkan spec has this regarding UpdateAfterBind limits:

The UpdateAfterBind descriptor limits must each be greater than or equal to the corresponding non-UpdateAfterBind limit.

However, the Mock ICD doesn't fill these values and returns 0. This results in validation layers when using the Mock ICD and asking for Vulkan version > 1.1, even though Mock ICD advertises support for the latest version:

    pProperties->apiVersion = VK_HEADER_VERSION_COMPLETE;

Either the Mock ICD should advertise only Version 1.1 or (better yet) fix these limits.

@spencer-lunarg
Copy link
Contributor

@ShabbyX we have had issue in the Validation Layers where MockICD doesn't return non-zero values, but then the question became

What should it return instead?

There is no "default" value in the XML to know what maxPerStageDescriptorUpdateAfterBindUniformBuffers needs to be minimum (I am currently tasked with help getting this generated https://gitlab.khronos.org/vulkan/vulkan/-/issues/3211)

but until then, the Validation Layers testing decided to use the new Profile Layer to have it return these limit values and just use MockICD to consume the Vulkan calls

@ShabbyX
Copy link
Contributor Author

ShabbyX commented Feb 7, 2023

(An eternity later)

Was that informational, or is there a question I should be answering? FYI, this is in the bottom of priority list for us

@spencer-lunarg
Copy link
Contributor

informational, this is higher on my priority to fix for us and taking notes for myself later 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants