Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use XML Formats to generate test json files #351

Open
spencer-lunarg opened this issue Jan 24, 2023 · 0 comments
Open

Use XML Formats to generate test json files #351

spencer-lunarg opened this issue Jan 24, 2023 · 0 comments

Comments

@spencer-lunarg
Copy link
Collaborator

spencer-lunarg commented Jan 24, 2023

Currently gen_profiles_tests.py is setting the format feature bits randomly

It would be nice to have a "max value" version where each format has all the feature bits possible set. There will need to be some exceptions, here is my break down I think should work

  • core (all formats could have)
    • VK_FORMAT_FEATURE_2_SAMPLED_IMAGE_BIT
    • VK_FORMAT_FEATURE_2_STORAGE_IMAGE_BIT
    • VK_FORMAT_FEATURE_2_STORAGE_IMAGE_ATOMIC_BIT
    • VK_FORMAT_FEATURE_2_UNIFORM_TEXEL_BUFFER_BIT
    • VK_FORMAT_FEATURE_2_STORAGE_TEXEL_BUFFER_BIT
    • VK_FORMAT_FEATURE_2_STORAGE_TEXEL_BUFFER_ATOMIC_BIT
    • VK_FORMAT_FEATURE_2_VERTEX_BUFFER_BIT
    • VK_FORMAT_FEATURE_2_BLIT_SRC_BIT
    • VK_FORMAT_FEATURE_2_BLIT_DST_BIT
    • VK_FORMAT_FEATURE_2_SAMPLED_IMAGE_FILTER_LINEAR_BIT
    • VK_FORMAT_FEATURE_2_SAMPLED_IMAGE_FILTER_CUBIC_BIT
    • VK_FORMAT_FEATURE_2_TRANSFER_SRC_BIT
    • VK_FORMAT_FEATURE_2_TRANSFER_DST_BIT
    • VK_FORMAT_FEATURE_2_SAMPLED_IMAGE_FILTER_MINMAX_BIT
    • VK_FORMAT_FEATURE_2_STORAGE_READ_WITHOUT_FORMAT_BIT
    • VK_FORMAT_FEATURE_2_STORAGE_WRITE_WITHOUT_FORMAT_BIT
    • VK_FORMAT_FEATURE_2_ACCELERATION_STRUCTURE_VERTEX_BUFFER_BIT_KHR
    • VK_FORMAT_FEATURE_2_FRAGMENT_DENSITY_MAP_BIT_EXT
    • VK_FORMAT_FEATURE_2_FRAGMENT_SHADING_RATE_ATTACHMENT_BIT_KHR
  • depth stencil (if XML <format> has <component name="D" or <component name="S")
    • VK_FORMAT_FEATURE_2_DEPTH_STENCIL_ATTACHMENT_BIT
    • VK_FORMAT_FEATURE_2_SAMPLED_IMAGE_DEPTH_COMPARISON_BIT
  • color (if not depth/stencil)
    • VK_FORMAT_FEATURE_2_COLOR_ATTACHMENT_BIT
    • VK_FORMAT_FEATURE_2_COLOR_ATTACHMENT_BLEND_BIT
  • YCbCr (if XML <format> has a <plane>)
    • VK_FORMAT_FEATURE_2_MIDPOINT_CHROMA_SAMPLES_BIT
    • VK_FORMAT_FEATURE_2_SAMPLED_IMAGE_YCBCR_CONVERSION_LINEAR_FILTER_BIT
    • VK_FORMAT_FEATURE_2_SAMPLED_IMAGE_YCBCR_CONVERSION_SEPARATE_RECONSTRUCTION_FILTER_BIT
    • VK_FORMAT_FEATURE_2_SAMPLED_IMAGE_YCBCR_CONVERSION_CHROMA_RECONSTRUCTION_EXPLICIT_BIT
    • VK_FORMAT_FEATURE_2_SAMPLED_IMAGE_YCBCR_CONVERSION_CHROMA_RECONSTRUCTION_EXPLICIT_FORCEABLE_BIT
    • VK_FORMAT_FEATURE_2_DISJOINT_BIT
    • VK_FORMAT_FEATURE_2_COSITED_CHROMA_SAMPLES_BIT
  • video (probably all formats can have too)
    • VK_FORMAT_FEATURE_2_VIDEO_DECODE_OUTPUT_BIT_KHR
    • VK_FORMAT_FEATURE_2_VIDEO_DECODE_DPB_BIT_KHR
    • VK_FORMAT_FEATURE_2_VIDEO_ENCODE_INPUT_BIT_KHR
    • VK_FORMAT_FEATURE_2_VIDEO_ENCODE_DPB_BIT_KHR

Any Vendor Format Features can just be ignored IMO

I would only generate the VkFormatProperties3 too as it will be the super set of VkFormatProperties

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant