Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vkGetPhysicalDevice*Properties functions don't have a way to return anything #341

Open
spencer-lunarg opened this issue Jan 16, 2023 · 0 comments

Comments

@spencer-lunarg
Copy link
Collaborator

spencer-lunarg commented Jan 16, 2023

some functions such as vkGetPhysicalDeviceImageFormatProperties or vkGetPhysicalDeviceMultisamplePropertiesEXT don't have a way for the Profiles system to capture and return back a value

Example:

the VkPhysicalDeviceSampleLocationsPropertiesEXT is the "minimum value" , so for example VkPhysicalDeviceSampleLocationsPropertiesEXT::maxSampleLocationGridSize might be (2, 2) which means it is that for all sample counts, but using the function you may find that the VK_SAMPLE_COUNT_8_BIT actually supports a VkMultisamplePropertiesEXT::maxSampleLocationGridSize up to (4, 4)

Use Case:

Currently the desired use case for this is the Validation Layers testing to be able to simulate this aspect of a driver, for now it might be a better solution to add this logic in the MockICD driver instead, but opening issue for future discussions/considerations

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants