Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C++20 module improvements #1815

Open
sharadhr opened this issue Feb 27, 2024 · 6 comments
Open

C++20 module improvements #1815

sharadhr opened this issue Feb 27, 2024 · 6 comments

Comments

@sharadhr
Copy link
Contributor

sharadhr commented Feb 27, 2024

There are a few things I'd like to improve about vulkan.cppm, stemming from my own experience, and bug reports around.

I'd like to spur some discussion on this, and if it's worthwhile, start a relevant PR.

@g-martin772
Copy link

Making the vulkan_hpp module work with import std; would be great!

@sharadhr
Copy link
Contributor Author

sharadhr commented Mar 6, 2024

@asuessenbach and @theHamsta, do you have any input on this? Thanks!

@asuessenbach
Copy link
Contributor

Please sorry for the delay.
I think, you're right, using import std seems to be the right move. Would be great if you could start a PR on it.

@stripe2933
Copy link

stripe2933 commented Mar 22, 2024

Hello, I created a draft commit for enable import std conditionally using VULKAN_HPP_USE_STD_MODULE CMake option. It works with my Clang 17 + custom libc++ build, but I have no idea that it works on other environment (also it may breaks the usage for non-module usage). Are there anything I should do before the PR? Here's the commit in the forked repository.

@sharadhr
Copy link
Contributor Author

Thanks @stripe2933! I've personally been putting off this because CMake 3.30 (probably releasing in a couple of months; 3.29 is already at rc4) will have full support for import std without our having to do much: https://gitlab.kitware.com/cmake/cmake/-/merge_requests/9337

@stripe2933
Copy link

Oh, I was one step behind. That sounds great. It will fix the module usage with MSVC.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants