New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pull requests status #80
Comments
Hi @imvucic, We're at face-to-face meetings this week which is slowing things down, but I'll make sure to review these today. |
Hi @gmlueck @mkinsner |
#85 is approved and merged. Please let us know if anything else is blocking progress. |
From USM we have the last one #87, that would be grate to be merged and following our Sprint 2 plans. |
I've approved and merged #91 to unblock progress on the next chapter. Will review the common interface PRs shortly |
One more general comment...Tomorrow is last day of our Sprint 3...In order to close appropriately we should receive review on all topics from PR list : https://github.com/KhronosGroup/SYCL_Reference/pulls |
All PRs have been approved and merged now, so thanks for making all requested changes so quickly |
Hi @mkinsner @gmlueck Thanks, |
Hi @mkinsner @gmlueck @tomdeakin
Your review and comments are crucial to ensure accuracy and alignment with our standards before finalizing the task, especially in part of adding new chapters for allocation more efforts and quality planning. Thanks in advince, |
Hi @mkinsner, Best regards, |
Hi @imvucic, I've now either approved and merged, approved (pending merge conflict resolution), or left comments on all of the open PRs. I'll monitor in the coming days and merge as the PRs are updated. I'll be out of office next week and for a few days the week after, but will try to be active reviewing PRs again starting Jan 3. |
Hi @mkinsner @gmlueck @tomdeakin Could you please provide here final comment and ensuring that the content provided is correct and complete, and consistent with the SYCL 2020 specifications and behavior? Thanks in advanced, |
Hi @imvucic I'm not aware of any remaining gaps, but also won't do a detailed comparison against the SYCL 2020 specification today. Has Intellias done a final analysis of the reference guide versus SYCL 2020, and believes that all gaps are closed (all SYCL 2020 API content is captured in the reference guide, and no SYCL 1.2.1 features which were removed in SYCL 2020 are in the reference guide)? Thanks, |
Hi @mkinsner, From Intellias we have done a final gap analysis in parallel and believes that all gaps are closed. Thanks and Best regards, |
We created this issue for discuss on PR in general - blocking points/force merge or other topics.
The first question is do you need some in addition to merge these two PRs :
#77
#76
It's important to us to close entire Sprint 1...
The second topic based on merge of #79...
Here we just changed files name like pre-requirement for Sprint 2 and easier work without conflict...content is old for now
It is important to have prepared asap.
Thanks,
Marko
The text was updated successfully, but these errors were encountered: