Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spriv-tools build of spirv-cross is really old #5526

Open
alecazam opened this issue Jan 11, 2024 · 3 comments
Open

spriv-tools build of spirv-cross is really old #5526

alecazam opened this issue Jan 11, 2024 · 3 comments
Assignees

Comments

@alecazam
Copy link

We ended up pulling copies of this from the VulkanSDK. But including a 2021 version of this alongside newer glslc/spirv-opt isn't ideal. I only found this out since I did a -version on all the tools.

@alecazam
Copy link
Author

Sorry this was the Win build(so spirv-cross.exe). I'm not sure about macOS build.

@s-perron
Copy link
Collaborator

@jeremyg-lunarg This seems to be an issue with the SDK.

I'm not too sure what is referred to. When I tried the tools on Linux, the SDK v1.3.261.1 has

~/VulkanSDK/1.3.261.1 » `find . -name spirv-opt` --version                                                                                                                                                                                             stevenperron@stevenperron-cloudtop
SPIRV-Tools v2023.4 v2022.4-296-ge553b884

and

~/VulkanSDK/1.3.261.1 » `find . -name spirv-cross` --help 2>&1 | head -2                                                                                                                                                                               stevenperron@stevenperron-cloudtop
Git commit: bccaa94d Timestamp: 2023-08-29T20:41:51
Usage: spirv-cross <...>

I don't see anything from 2021. @alecazam Is it possible you have a different spirv-opt or spirv-cross on your path?

@jeremy-lunarg
Copy link
Contributor

Reiterating on what @s-perron said, the spirv-cross from the latest vulkan sdk has the timestamp 2023-10-17T17:31:47. @alecazam, which "build of spirv-cross" is old? I don't an issue with what's provided in the latest SDK.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants
@alecazam @jeremy-lunarg @s-perron @jeremyg-lunarg and others