You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
If two SPIR-V programs have identical instructions streams except for some reversible substitution of ids, it seems like it should be possible for spirv-diff to always recognize them as identical. One reason #5218 wasn't caught before is that many of the test programs have %2 = OpTypeVoid, so comparing src and dst ids without applying the mapping just happened to produce matches anyway.
It would be pretty easy to catch mistakes like this by taking every .spvasm file in test/diff/diff_files, permuting its ids, and checking that Differ reports no changes.
The text was updated successfully, but these errors were encountered:
If two SPIR-V programs have identical instructions streams except for some reversible substitution of ids, it seems like it should be possible for
spirv-diff
to always recognize them as identical. One reason #5218 wasn't caught before is that many of the test programs have%2 = OpTypeVoid
, so comparing src and dst ids without applying the mapping just happened to produce matches anyway.It would be pretty easy to catch mistakes like this by taking every
.spvasm
file intest/diff/diff_files
, permuting its ids, and checking thatDiffer
reports no changes.The text was updated successfully, but these errors were encountered: