Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spirv-diff should test that merely permuting ids never produces a diff #5228

Open
jimblandy opened this issue May 22, 2023 · 0 comments
Open
Labels
component:diff Issues related to spirv-diff feature request

Comments

@jimblandy
Copy link
Contributor

If two SPIR-V programs have identical instructions streams except for some reversible substitution of ids, it seems like it should be possible for spirv-diff to always recognize them as identical. One reason #5218 wasn't caught before is that many of the test programs have %2 = OpTypeVoid, so comparing src and dst ids without applying the mapping just happened to produce matches anyway.

It would be pretty easy to catch mistakes like this by taking every .spvasm file in test/diff/diff_files, permuting its ids, and checking that Differ reports no changes.

@s-perron s-perron added component:diff Issues related to spirv-diff feature request labels Jun 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:diff Issues related to spirv-diff feature request
Projects
None yet
Development

No branches or pull requests

2 participants