Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Possibly access to freed memory when using WASM build. #5036

Open
farmaazon opened this issue Dec 21, 2022 · 0 comments · May be fixed by #5047
Open

Possibly access to freed memory when using WASM build. #5036

farmaazon opened this issue Dec 21, 2022 · 0 comments · May be fixed by #5047
Assignees
@dneto0
Labels
component:wasm

Comments

@farmaazon
Copy link

farmaazon commented Dec 21, 2022 •
edited

The dis function returns a typed_view constructed from pointer to vector data which are promptly destructed (here)
@farmaazon farmaazon mentioned this issue Dec 22, 2022
Open
dneto0 added a commit to dneto0/SPIRV-Tools that referenced this issue Dec 22, 2022
@dneto0
wasm: Avoid use-after-free from the assembler
ee08ca1 
Copy the data out instead of returning a view into a locally-declared vector.

Fixes: KhronosGroup#5036
@dneto0 dneto0 mentioned this issue Dec 22, 2022
Closed
dneto0 added a commit to dneto0/SPIRV-Tools that referenced this issue Dec 22, 2022
@dneto0
WIP: Add Wasm build for SPIRV-Tools-opt
0e9cdf4 
Fixes: KhronosGroup#5029
Fixes: KhronosGroup#5036
@dneto0 dneto0 linked a pull request Dec 22, 2022 that will close this issue
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dneto0 dneto0

Labels
component:wasm
Projects
None yet
Milestone
No milestone
3 participants
@farmaazon @dneto0 @s-perron