Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix use of strcat_s when parsing SpvOpSourceContinued #128

Open
gmueckl opened this issue Sep 27, 2021 · 4 comments
Open

Fix use of strcat_s when parsing SpvOpSourceContinued #128

gmueckl opened this issue Sep 27, 2021 · 4 comments

Comments

@gmueckl
Copy link
Contributor

gmueckl commented Sep 27, 2021

When concatenating the source strings while parsing SpvOpSourceContinued, strcat_s is called with a wrong length for the target buffer on Windows. PR #127 is a suggested fix.
@chaoticbob
Copy link
Contributor

Hi,

Sorry for the delay, yep looks like a legit bug. Would you mind signing the CLA for #127?

Thanks,
Hai

@phradsky
Copy link

phradsky commented Feb 1, 2022

Hi, we've also run into this bug and fixed it locally the same way. Could this please be signed? Thanks.

@gmueckl
Copy link
Contributor Author

gmueckl commented Feb 1, 2022

The CLA is signed. Is something else missing?

@phradsky
Copy link

phradsky commented Feb 1, 2022

Hi, sorry for my wording, I'm still a bit new to GIT. I see the #127 is still not merged to master, I downloaded the ZIP and the fix isn't there yet, only now I saw the merge request is still open.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@chaoticbob @gmueckl @phradsky