Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handler settings are string-only in schema, so e.g., boolean settings, are reported as errors #493

Open
kdx-perbol opened this issue Apr 17, 2023 · 2 comments
Assignees
Labels
12.x NETCORE uSync v12 things Breaking Change A Change that might impact 3rd party code, or change the format of export files

Comments

@kdx-perbol
Copy link

Describe the bug
uSync Handler settings are string-only in the uSync appSettings schema, so e.g., boolean settings, are reported as errors.

To Reproduce
Steps to reproduce the behavior:

  1. Follow https://docs.jumoo.co.uk/usync/uSync/guides/dictionary/#make-the-dictionary-handler-create-only
  2. Observe error squiggles

Expected behavior
No squiggles. :)

About your Site (please complete the following information):

  • uSync Version: latest

Additional context

    "USyncBackOfficeConfigurationHandlerSettings": {
      "properties": {
        "Settings": {
          "additionalProperties": {
            "type": "string"
          }

@kdx-perbol
Copy link
Author

Putting true and ignoring squiggles for now.

@KevinJump
Copy link
Owner

Hi,

yes this is because internally we are using a dictionary<string,string> for the settings and when the schema is generated, its picking that up. (it does work with ether true or "true",

Unfortunately changing this to dictionary<string, object> will be a breaking change - so we will have to wait for a major release to make the change.

@KevinJump KevinJump added the Breaking Change A Change that might impact 3rd party code, or change the format of export files label May 11, 2023
@KevinJump KevinJump self-assigned this May 11, 2023
@KevinJump KevinJump added the 12.x NETCORE uSync v12 things label May 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
12.x NETCORE uSync v12 things Breaking Change A Change that might impact 3rd party code, or change the format of export files
Projects
None yet
Development

No branches or pull requests

2 participants