Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kavita fails to ignore @eaDir. Regression of #311 #2946

Open
MaxRenaud opened this issue May 7, 2024 · 1 comment
Open

Kavita fails to ignore @eaDir. Regression of #311 #2946

MaxRenaud opened this issue May 7, 2024 · 1 comment
Labels
can't reproduce Can't reproduce, need additional information from user

Comments

@MaxRenaud
Copy link

What happened?

I have some manga stored on a Synology NAS which creates extended directory attributes under a @eadir directory. #311 committed a fix 3 years ago but Kavita still indexed the @eadir files.

this is the path that was indexed:

./DLRAW.TO_Fujiko F. Fujio Daizenshu Doraemon vol 01-20/DLRAW.TO_Fujiko F. Fujio Daizenshu Doraemon v11-15/DLRAW.TO_小学館 藤子・F・不二雄大全集 ドラえもん 第13巻/@eaDir/DLRAW.TO_00624.jpeg@SynoEAStream

These files aren't jpeg but Kavita indexes them and tries to serve them. I confirmed this by downloading the image and receiving DLRAW.TO_00624.jpeg@SynoEAStream through the browser.

The regex in #311 seems correct and inputting @eaDir|\.DS_Store in a Regex tester with the path above returns a match. I also tried @eaDir|\.DS_Store|\.qpkg|__MACOSX|@Recently-Snapshot|@recycle|\.@__thumb|\.caltrash|#recycle which is what's in 0.8.1.

I don't have experience with C# and don't understand why this is happening so I'm hoping someone with more experience with the project or language can chime in.

What did you expect?

I expected the manga viewer to display jpeg instead of the @SynoEAStream file under the @eadir directory. Under the hood, I believe these are to be ignored by the indexer altogether but how these are ignored isn't an expectation; just that they are ignored from the viewer.

Kavita Version Number - If you don not see your version number listed, please update Kavita and see if your issue still persists.

0.8.1 - Stable

What operating system is Kavita being hosted from?

Docker (LSIO Container)

If the issue is being seen on Desktop, what OS are you running where you see the issue?

Mac

If the issue is being seen in the UI, what browsers are you seeing the problem on?

Chrome

If the issue is being seen on Mobile, what OS are you running where you see the issue?

None

If the issue is being seen on the Mobile UI, what browsers are you seeing the problem on?

No response

Relevant log output

No response

Additional Notes

Running on Kubernetes and pulled latest, which points to v0.8.1-ls36

@MaxRenaud MaxRenaud added the needs-triage Needs to be triaged by a developer and assigned a release label May 7, 2024
@majora2007 majora2007 added this to To do in v0.8 - PDF & Comic Love via automation May 8, 2024
@majora2007 majora2007 moved this from To do to In progress in v0.8 - PDF & Comic Love May 14, 2024
@majora2007 majora2007 added can't reproduce Can't reproduce, need additional information from user and removed needs-triage Needs to be triaged by a developer and assigned a release labels May 14, 2024
@majora2007
Copy link
Member

I'm unable to reproduce this. Here is my simple test case.

Library root: E:/test
Series in: E:/test/test/@eaDir/My Daughter..../files.cbz

image

[Kavita] [2024-05-14 17:59:01.081 -05:00  53] [Debug] API.Services.Tasks.ScannerService [ScannerService] Found 0 files for E:\test\test
[Kavita] [2024-05-14 17:59:01.081 -05:00  53] [Information] API.Services.Tasks.ScannerService [ScannerService] E:\test\test is empty, no longer in this location, or has no file types that match Library File Types

Nothing is found as @eaDir is a blacklisted folder.

@majora2007 majora2007 moved this from In progress to Can't Reproduce in v0.8 - PDF & Comic Love May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
can't reproduce Can't reproduce, need additional information from user
Projects
v0.8 - PDF & Comic Love
  
Can't Reproduce
Development

No branches or pull requests

2 participants