Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Discuss] Exported images had no background in dark mode, making the labels hard to recognize #59

Open
Kytscho opened this issue Apr 14, 2023 · 3 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@Kytscho
Copy link

Kytscho commented Apr 14, 2023

The image I exported
gw chart 913200

Ths is how it looked in my explorer
screenshot-20230414-231145

Noticed the background is transparent but image explorers usually make a white background, so that the text contents are hard to recognize. I wonder if there will be an option to control the background, or just to capture the appearance in my browser. thx.

@AntoineYANG AntoineYANG changed the title [Bug] Exported images had no background in dark mode, making the labels hard to recognize [Discuss] Exported images had no background in dark mode, making the labels hard to recognize Apr 14, 2023
@AntoineYANG AntoineYANG added enhancement New feature or request good first issue Good for newcomers labels Apr 14, 2023
@nc1337
Copy link

nc1337 commented Apr 16, 2023

Hi @AntoineYANG, i am new to this project and would love to contribute. Could you kindly help me get started here.
Also i have the local dev setup done and good to go.

@AntoineYANG
Copy link
Contributor

Hi @AntoineYANG, i am new to this project and would love to contribute. Could you kindly help me get started here. Also i have the local dev setup done and good to go.

Glad to have you here @nc1337 ! We encourage contributions and everyone can contribute to this project. You can take and do something with this issue if you'd like to. I assume you have already checked the license and README. So the usual procedure to get contributing is to

  1. Fork the graphic-walker repository.
  2. Commit your code.
  3. Creating a PR from your branch to the main branch, with an introduction to your changes, and cite this issue in it.

Members will check open PRs and keep contacting with contributors.

@ObservedObserver
Copy link
Member

Guides for contributors:

The background of visualization is now set by default to transparent in https://github.com/Kanaries/graphic-walker/blob/main/packages/graphic-walker/src/vis/theme.ts

  1. Config can be added to store visualConfig to allow the user to set the background manually.
  2. it might be a good idea to set the theme config to non-transparent value by default

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

4 participants