New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dg dataset in vlcs #57

Open

hopey233 opened this issue Mar 24, 2023 · 0 comments

hopey233 commented Mar 24, 2023

sorry to disturb you.

in my domain generalization task, i find a mistake in https://github.com/KaiyangZhou/Dassl.pytorch/blob/master/dassl/data/datasets/dg/vlcs.py#L40

because in the test data, it should inlcude all images in target domain, so it should be written as follows:

test = self._read_data(cfg.DATASET.TARGET_DOMAINS, "full")
test += self._read_data(cfg.DATASET.TARGET_DOMAINS, "test")

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment