Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove hardcoded color from cli/kaos_cli/commands/build.py #99

Open
atselikov opened this issue Dec 16, 2019 · 2 comments
Open

Remove hardcoded color from cli/kaos_cli/commands/build.py #99

atselikov opened this issue Dec 16, 2019 · 2 comments
Assignees

Comments

@atselikov
Copy link
Contributor

What is the desired change?

Based on code review last week it would be nice to make terminal color handling in
cli/kaos_cli/commands/build.py
in the same way, as we have it in other modules (train, serve, etc...):

@build.command(name='deploy',
               short_help='{}'.format(
                   click.style('Build the kaos backend', bold=True, fg='black')))

->

@serve.command(name='deploy',
               short_help='Configure and serve an ML model')

How will this change improve kaos?

No point to have command's color hardcoded (maybe apart of kill command warning).
As we saw on the code review demo - it could be invisible because of a terminal different color scheme.

Any thoughts on the implementation approach?

Refactoring

@ms-shankar
Copy link
Contributor

  1. The color scheme bug is fixed under the PR K-80: tf state file handling for multiple deployments #95.
  2. Also added more description based on newly added feature

@ms-shankar
Copy link
Contributor

Screen Shot 2020-01-24 at 09 47 32

Screen Shot 2020-01-24 at 09 47 46

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants