Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better constants handling #98

Open
atselikov opened this issue Dec 16, 2019 · 0 comments
Open

Better constants handling #98

atselikov opened this issue Dec 16, 2019 · 0 comments

Comments

@atselikov
Copy link
Contributor

What is the desired change?

Based on code review last week it would be nice to change the way we deal with constants:

from kaos_cli.constants import PACHYDERM, BACKEND
...
return self.state_service.get(PACHYDERM, 'workspace')

->

from kaos_cli import constants
...
return self.state_service.get(constants.PACHYDERM, 'workspace')

How will this change improve kaos?

More transparency in constants handling

Any thoughts on the implementation approach?

Code refactoring
@atselikov atselikov changed the title Better constants management Better constants handling Dec 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@atselikov