New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

validate source_bundle shebang (in ./train) #67

Open

jfri3d opened this issue Nov 6, 2019 · 0 comments

Assignees

Labels

documentation good first issue

Projects

Collaborator

jfri3d commented Nov 6, 2019

What is the desired change?

Enforce validation of the ./train executable within the source_bundle to ensure a shebang exists!!!

#!/usr/bin/env XXXXXX

ALSO ensure documentation is adjusted to "remind" users that the Train Pipeline uses ./train as an executable.

How will this change improve kaos?

Improve usability to avoid broken trainings where ./train can't run...

Any thoughts on the implementation approach?

Validate in the backend. Inspiration below.

kaos/backend/kaos_backend/util/validators.py

Line 66 in e638d28

def validate_bundle_structure(cls, directory, req_files):

The text was updated successfully, but these errors were encountered:

jfri3d added documentation good first issue labels

jfri3d added this to To do in kaos via automation

ms-shankar self-assigned this

ms-shankar mentioned this issue

K-67: Validate if train/serve file is executable #72

Open

8 tasks

jfri3d moved this from To do to In progress in kaos

ms-shankar moved this from In progress to Done in kaos

ms-shankar moved this from Done to In Review in kaos

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment