Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perfparser: add elfutlis version info to --version (and its debug symbols in the debuginfo appimage package) #560

Closed
GitMensch opened this issue Nov 12, 2023 · 2 comments

Comments

@GitMensch
Copy link
Contributor

Is your feature request related to a problem? Please describe.
I'm inspecting issues seen in perfparser and find it hard to go on with the appimage provided version.

One of the reasons is that appimage creation uses centos7 (I guess it is still at "debuginfod only for centos8+9 state) and more important: the elfutils used, which make the biggest part of perfutils (perf record shows 98.5% spent in hotspot-perfparser is in PerfRecordSample::PerfRecordSample(PerfRecordSample&&)), is statically linked, so not well visible with ldd either.

Describe the solution you'd like
Include elfutils version in an extra line in hotspot-perfparser - both to make it more clear what is used and to give credits to the library that seems to do most of the actual work.
Furthermore it would be very good if the appimage debuginfo download could include the elfutils debuginfo package.

Describe alternatives you've considered
None.

@GitMensch
Copy link
Contributor Author

The first part was tackled with by @lievenhey with KDAB/perfparser@9b3ff41 and will be solved on the next perfparser revision update.
The second one needs to be handled in creating the debuginfo appimage package (but I haven't looked how this is created so far).

lievenhey added a commit that referenced this issue Jan 29, 2024
this patch adds the elfutils debuginfo files to the debuginfo.zip file
fixes: #560
lievenhey added a commit that referenced this issue Jan 29, 2024
this patch adds the elfutils debuginfo files to the debuginfo.zip file
fixes: #560
lievenhey added a commit that referenced this issue Jan 29, 2024
this patch adds the elfutils debuginfo files to the debuginfo.zip file
fixes: #560
@lievenhey
Copy link
Contributor

The debug symbols are available at: https://github.com/KDAB/hotspot/releases/tag/qt-debuginfo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants