Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

M4A1 DD Anti-installation calculation not implemented #2987

Open
Deidryt opened this issue May 1, 2020 · 1 comment
Open

M4A1 DD Anti-installation calculation not implemented #2987

Deidryt opened this issue May 1, 2020 · 1 comment

Comments

@Deidryt
Copy link

Deidryt commented May 1, 2020

The anti-installation damage calculations do not take into account the M4A1 DD's bonuses currently. The appropriate values can be found in the Kantai-Collection Discord or this chart:
https://i.imgur.com/oR7PmAC.png
sinsinpub added a commit that referenced this issue May 6, 2020
@sinsinpub
Update anti-land mods, related to #2987:
684bd78 
* Add M4A1 DD mods and update formula according Nishi's UnexpectedDamage.js
  * Please check and fix me if i'm wrong!
    i guess i haven't full understanded the new anti-land formula yet.
    @sorewachigauyo
* Update carrier day shelling power to no TP visible bonus
* Update TL pointer
@Deidryt
Copy link
Author

Deidryt commented Jun 5, 2020

The multipliers look right now... (though I'm confused by some of the other values in the arrays, such as the T89 numbers -- not sure how the math works with the values in the linked resource).

The SS/SSV and Shikon/M41DD "25" bonus looks right, as is the detection for the M41DD "1.4" multiplier. (Was initially confused a bit how "0,0,1" was being passed in the various airstrike cases).

Overall, it looks right to me -- however, the immense overhaul of the Anti-Install damage equation certainly invites more people to look over it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Deidryt