Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preconditionning #7

Open
rveltz opened this issue Oct 29, 2018 · 6 comments
Open

Preconditionning #7

rveltz opened this issue Oct 29, 2018 · 6 comments

Comments

@rveltz
Copy link
Contributor

rveltz commented Oct 29, 2018

Hi,

I have become addicted to your package. The downside is that I would like an additional feature ;)
I use Arnoldi iterations for computing the spectrum and the convergence is super slow.
So, I was wondering how difficult it would be for you to add support for preconditionning?

Thank you a lot for your help,

Best regards

@Jutho
Copy link
Owner

Jutho commented Oct 29, 2018

Thanks. I think the hardest part is coming up with a nice and convenient interface. Unfortunately, I don't have much time for this right now. I would certainly be welcome to any contributions.

@rveltz rveltz closed this as completed Oct 30, 2018
@Jutho
Copy link
Owner

Jutho commented Oct 30, 2018

No need to close this; it's good to let feature requests hang around as open issues.

@Jutho Jutho reopened this Oct 30, 2018
@rveltz
Copy link
Contributor Author

rveltz commented Oct 22, 2019

Don't you like the interface from IterativeSolvers? ie a keywork argument Pl = Idendity where one could use functions or matrices. Is it a lot of work to add? Especially to eigsolve?

@Jutho
Copy link
Owner

Jutho commented Oct 28, 2019

It's rather an issue of a lack of expertise from my side. I have no experience with preconditioners, as there are typically no obvious choices in the cases where I am solving eigenvalue and linear problems. And if there are, they are usually incorporated in a more explicit way, i.e. by transforming to a new set of variables.

The lack of self-need is also why I can't afford to invest too much time in this, at least not right now. But I do welcome any contribution in that direction.

@rveltz
Copy link
Contributor Author

rveltz commented Oct 31, 2019

And if there are, they are usually incorporated in a more explicit way, i.e. by transforming to a new set of variables.

It is not always possible. For example, doing so you transform an eigenvalue problem into a generalized one and geneigsolve is quite restrictive.

@Jutho
Copy link
Owner

Jutho commented Nov 4, 2019

Exactly, in the applications I am working with, we often have a generalized eigenvalue problem that, by parameterizing the problem in terms of a more suitable set of variables, is transformed into a normal eigenvalue problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants