Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change /glow and /removeglow to use reasonable enchantment levels. #138

Open
JustBru00 opened this issue Apr 14, 2020 · 5 comments
Open
Assignees
Labels
Milestone

Comments

@JustBru00
Copy link
Owner

JustBru00 commented Apr 14, 2020

Right now /glow uses a high level 4341 enchantment. Should attempt to change it to something different.
I think there is invisible tags now that can be applied to items.

@JustBru00 JustBru00 self-assigned this Apr 14, 2020
@JustBru00 JustBru00 added this to the v3.8 milestone Apr 14, 2020
@JustBru00 JustBru00 modified the milestones: v3.8, v3.9 May 25, 2020
@JustBru00 JustBru00 modified the milestones: v3.9, v3.11 Sep 29, 2020
@JustBru00
Copy link
Owner Author

Saw another plugin use enchantment level 0.
That may work if I cannot add extra data to the item.

@JustBru00
Copy link
Owner Author

JustBru00 commented Oct 1, 2022

Tested today and found that even enchantment level 0 still provides experience when removed with a grindstone. I did discover that a PR was opened on PaperMC that would allow me to fix this issue. PaperMC/Paper#5274
PaperMC/Paper#5725

@JustBru00 JustBru00 added the Upstream Issues caused spigot, paper or vanilla minecraft. label Oct 1, 2022
@JustBru00 JustBru00 modified the milestones: v3.11, v3.12 Oct 1, 2022
@JustBru00
Copy link
Owner Author

This might be helpful if I can find a way to prevent the grindstone experience. https://www.spigotmc.org/threads/tutorial-storing-custom-data-on-itemstacks-in-1-13-2.354283/

@LOOHP
Copy link

LOOHP commented Nov 22, 2022

You can mark the item as glowing by adding a tag in the item's persistent data container. And check inventory events when using grindstone.

@JustBru00 JustBru00 modified the milestones: v3.12, v3.13 Jan 27, 2023
@JustBru00
Copy link
Owner Author

This might allow an easy way to fix this. PaperMC/Paper#8711

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants