All effective waves should have the same structure

[arturgower]

The effective wave types should have the same structure. For example see EffectivePlaneWaves

EffectiveWaves.jl/src/wave_types.jl

Lines 39 to 45 in c6ad025

	struct EffectivePlaneWaveMode{T<:AbstractFloat,Dim} <: AbstractWaveMode{T,Dim}
	ω::T
	wavenumber::Complex{T}
	basis_order::Int
	direction::SVector{Dim,Complex{T}} # the effective direction where sum(direction.^2) == 1
	eigenvectors::Array{Complex{T}} # the effective ampliudes
	end

Each effective wave type should have only enough information for fully describe the value of this wave at some point in space.

The necessary fields are the eigenvectors, basis_order, wavenumber, and ω. Extra fields should be used sparring and only when necessary. This is certainly not the case for:

EffectiveWaves.jl/src/wave_types.jl

Lines 88 to 96 in c6ad025

	struct EffectiveRegularWaveMode{T<:AbstractFloat,Dim,P<:PhysicalMedium{T,Dim},S<:AbstractSetupSymmetry{Dim}} <: AbstractRegularWaveMode{T,Dim}
	ω::T
	wavenumber::Complex{T}
	medium::P
	material::Material{Dim}
	eigenvectors::Array{Complex{T}} # the effective eigenvectors, each column is one eigenvector
	basis_order::Int
	basis_field_order::Int
	function EffectiveRegularWaveMode(ω::T, wavenumber::Complex{T}, source::AbstractSource{T}, material::Material{Dim}, eigenvectors::Array{Complex{T}};