Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What should default_brettel_neutral be? #502

Closed
kimikage opened this issue Jul 22, 2021 · 1 comment
Closed

What should default_brettel_neutral be? #502

kimikage opened this issue Jul 22, 2021 · 1 comment

Comments

@kimikage
Copy link
Collaborator

default_brettel_neutral is used as a reference value in the simulation of color deficiency.

# This is supposed to be "the brightest possible metamer of an equal-energy
# stimulus". I'm punting a bit and just calling that RGB white.
const default_brettel_neutral = convert(LMS, RGB(1, 1, 1))

Since sRGB has a white point of D65, this looks more straightforward with convert(LMS, WP_D65).
However, why is WP_D65 used instead of WP_E (equal-energy)?

If we change it, it may affect the default color scheme of Gadfly etc. Therefore, rather than change the behavior, I would like to make the third argument of protanopic etc. a public API and make the documentation explicit.

cc: @dcjones
GiovineItalia/Compose.jl@9c3a046

@dcjones
Copy link
Contributor

dcjones commented Jul 22, 2021

It probably should be WP_E, and I just didn't quite know what I was doing when I wrote that.

Changing it does affect Gadfly's default color scheme, but I don't find the change to be bad per se.

Here's what the change looks like, if anyone cares to disagree:
image

@kimikage kimikage closed this as not planned Won't fix, can't repro, duplicate, stale May 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants