Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Road to 1.0 #361

Open
3 of 4 tasks
timholy opened this issue Nov 22, 2019 · 12 comments
Open
3 of 4 tasks

Road to 1.0 #361

timholy opened this issue Nov 22, 2019 · 12 comments

Comments

@timholy
Copy link
Member

timholy commented Nov 22, 2019

I'd like to move the whole JuliaImages stack to version numbers >= 1.0 (see JuliaImages/Images.jl#825). Let's use this issue to collect plans for breaking changes in the near future.

Issues/PRs on my agenda:

@kimikage
Copy link
Collaborator

kimikage commented Nov 23, 2019

Actually, I have forgotten how far I have worked 😅, but somethings should have already been achieved.
master...kimikage:cnvt

However, there are few breaking changes other than the bug fixes. In regards to the white point wp, it follows the current interface (convert(::Type{C}, c::Color, wp::XYZ)), but it is necessary to discuss how white points should be handled.

@timholy
Copy link
Member Author

timholy commented Nov 23, 2019

You have done wonders for these packages.

"Cleanups" can be done after 1.0 if they don't break the public API. If we grossly change the result of a white-point aware conversion, though, that is certainly breaking.

@kimikage
Copy link
Collaborator

kimikage commented Dec 9, 2019

CC @cormullion

It may be useful for the testing to add "julia_blue", "julia_green", "julia_purple" and "julia_red" to the named colors. I also feel that "nationalism" is too much, though. 😄

@cormullion
Copy link
Member

No problem. What do you mean by "I also feel that "nationalism" is too much, though."?

@kimikage
Copy link
Collaborator

kimikage commented Dec 9, 2019

Adding "julia_blue" etc. to the named colors is not necessarily a public interest.
"Colors of the Julia users, by the Julia users, for the Julia users!"

@cormullion
Copy link
Member

Ah, I see. :) Anyway, probably not many people use them (apart from me, I expect)...

@kimikage

This comment has been minimized.

@kimikage
Copy link
Collaborator

kimikage commented Aug 2, 2021

@jonathanBieler
Copy link

jonathanBieler commented Sep 14, 2022

If there breaking changes in master currently ? I wanted to use some of the XYZ to RGB conversion but last release was before it was added (27 Apr 2021). Would it be possible to make a minor release before 1.0 ?

@timholy
Copy link
Member Author

timholy commented Sep 14, 2022

Yeah, we need to do something about this. I am pretty swamped with TTFX work until at least mid-October, unfortunately. If you'd be willing to figure out what to do perhaps we could review your work and then make a release.

@jonathanBieler
Copy link

I had a look at the merged PRs and there's a couple labelled as breaking since last release :

Otherwise it's mostly performance & accuracy improvements, with a few new features (polar_to_cartesian, weighted_color_mean, ...). I don't see serious open issues either, so it seems reasonable to make a new release. But maybe @kimikage has a different opinion ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants