I'll take a look at this this weekend.

This looks decent to me. So no actual code changes are needed for Blink.jl? If that's the case, this can just be a patch release.

Maybe you forgot about this one

JuliaGizmos/Blink.jl#201

It seems to work for me anyway

I cant get the tests running locally, the npm call doesn't spawn. But if you can approve the CI here we can see if it runs

Codecov Report

Merging #478 (4911003) into master (91156f8) will increase coverage by 1.04%.
The diff coverage is 80.00%.

@@            Coverage Diff             @@
##           master     #478      +/-   ##
==========================================
+ Coverage   59.70%   60.75%   +1.04%     
==========================================
  Files          16       15       -1     
  Lines         757      739      -18     
==========================================
- Hits          452      449       -3     
+ Misses        305      290      -15     

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 91156f8...4911003. Read the comment docs.

I dont really understand that documentation failure. Any ideas?

Ok I think I've fixed this, if you can try running it again. I have a type stability PR ready too that builds on this, so if we can get this merged I can get that started.

bump

@travigd can you switch the github actions permissions over to "Require approval for first-time contributors"?

It's hard to debug the docs problems currently

@travigd lets get this merged before I forget about it. There is a problem with building the docs on github actions.

If you change the github actions permissions over as mentioned above I can get it passing. Approving every CI run on every push to JuliaGizmos PRs doesn't seem to be a good use of your time to me!

Now all the other PRs are registered, this PR still reduces the time to both first Interact.jl slider and Blink..jl Window by ~1 second, depending on your machine.

It's not as much as before, because a lot of the time was Parsers.jl, and that's fixed now. But still a nice improvement.

Sorry for being incommunicado recently. My life has been hectic and I use Julia very little in my day-to-day work life nowadays.

The docs build is failing because the build step fails (or just isn't run?) in CI. There are a few possible solutions:

• Build it in the CI for docs. This would require install nodejs so it can run all the JS toolchain stuff.
• Change the error(...) in __init__ to be a log warning (e.g., @error).
• Have the bundle_key ref be initialized lazily as a function:

  _bundle_key_ref = Ref{String}("")
  function _bundle_key()
    current = _bundle_key_ref[]
    if current == ""
      # try to initialize it here
    end
    return current
  end
  
  # later
  string(base, _bundle_key())

I'm partial to the third option.

(also FYI, I had to set it to only restrict actions for accounts new to github, not just new contributors, since you don't actually count as a contributor until something is merged)