Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Too tight tolerance in time test #192

Open
KristofferC opened this issue Dec 11, 2019 · 0 comments
Open

Too tight tolerance in time test #192

KristofferC opened this issue Dec 11, 2019 · 0 comments

Comments

@KristofferC
Copy link

It seems this package sometimes error with

dt = 1.384542466
fpswhen: Test Failed at /home/pkgeval/.julia/packages/Reactive/g1LZ6/test/time.jl:22
  Expression: isapprox(dt, 1, atol=0.3)
   Evaluated: isapprox(1.384542466, 1; atol=0.3)
Stacktrace:
 [1] top-level scope at /home/pkgeval/.julia/packages/Reactive/g1LZ6/test/time.jl:22
 [2] top-level scope at /workspace/srcdir/julia/usr/share/julia/stdlib/v1.3/Test/src/Test.jl:1107
 [3] top-level scope at /home/pkgeval/.julia/packages/Reactive/g1LZ6/test/time.jl:4
 [4] top-level scope at /workspace/srcdir/julia/usr/share/julia/stdlib/v1.3/Test/src/Test.jl:1107
 [5] top-level scope at /home/pkgeval/.julia/packages/Reactive/g1LZ6/test/time.jl:3

from https://github.com/maleadt/BasePkgEvalReports/blob/df660562b2dd1fc99b44e1ea582934701d8d421f/8639e57_vs_46ce4d7/logs/Reactive/1.3.1-pre-8639e5771d.log#L77-L85

It would be good if this could be fixed because it contributes some noise to the automatic tests on packages we run on different Julia versions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant