Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Index type #396

Open
vchuravy opened this issue May 10, 2023 · 4 comments
Open

Index type #396

vchuravy opened this issue May 10, 2023 · 4 comments
Labels
breaking change

Comments

@vchuravy
Copy link
Member

Int32 can be quite a bit faster and we should make sure that we use it where we can for our index calculations.
@vchuravy
Copy link
Member Author

@luraess also mentioned that it would make sense to configure the hardware dimension index into the Kernel struct.

@simonbyrne
Copy link
Collaborator

simonbyrne commented Jul 16, 2023 •
edited

Could you provide a function that would evaluate differently depending on the device? e.g.

IT = KernelAbstractions.IndexType()

@brabreda
Copy link

brabreda commented Sep 1, 2023

In which case or device would int32 not be sufficient?

@vchuravy
Copy link
Member Author

vchuravy commented Sep 1, 2023 •
edited

The maximum linear index with UInt32 is 4,294,967,295 so an array of about 4GB. With GPUs having upwards of 40GB or more memory in the data canter, it's not unlikely that a user want to process something larger than that.

In particular ML

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking change
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@vchuravy @simonbyrne @brabreda